Ethereal-dev: Re: [Ethereal-dev] New Dissector: Dumb Question

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Tue, 25 Jan 2005 16:51:42 +1100
And you followed the advice in :
http://anonsvn.ethereal.com/viewcvs/viewcvs.py/trunk/doc/README.developer?rev=12979&view=auto


and made sure the important signatures were :
  /* Register the protocol with Ethereal */

  /* this format is require because a script is used to build the C function
     that calls all the protocol registration.
  */

  void
  proto_register_PROTOABBREV(void)
  { 

and
  void
  proto_reg_handoff_PROTOABBREV(void)
  {
                
it is important that these two functions are declared exactly like
that  or else the script that builds register.c will fail to find
them.




On Mon, 24 Jan 2005 23:12:09 -0500, Alex Kirk <alex@xxxxxxxxxxxx> wrote:
> Under ideal circumstances, yes. However:
> 
> alex@sf: ~/downloads/ethereal-0.10.9$ grep wins epan/dissectors/register.c
> alex@sf: ~/downloads/ethereal-0.10.9$ ls -l epan/dissectors/packet-wins.c
> -rw-r--r--    1 akirk    research     5487 Jan 24 14:52
> epan/dissectors/packet-wins.c
> alex@sf: ~/downloads/ethereal-0.10.9$ sudo make install
> <Much verbosity of make install snipped>
> alex@sf: ~/downloads/ethereal-0.10.9$ grep wins epan/dissectors/register.c
> alex@sf: ~/downloads/ethereal-0.10.9$
> 
> Obviously, *something* is not working properly here. Especially since:
> 
> alex@sf: ~/downloads/ethereal-0.10.9$ grep wins epan/dissectors/Makefile.common
>        packet-wins.c   \
> alex@sf: ~/downloads/ethereal-0.10.9$
> 
> I've tried make clean, make distclean, and even working with a freshly unpacked
> tarball -- nada. Any ideas?
> 
> Alex Kirk
> 
> > When you run make, a nifty Python script should generate a new
> > register.c containing your dissector.
> >
> > Cheers
> >
> > > -----Original Message-----
> > > From: ethereal-dev-bounces@xxxxxxxxxxxx
> > > [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Alex Kirk
> > > Sent: Monday, January 24, 2005 2:15 PM
> > > To: Ethereal development; Ulf Lamping
> > > Subject: Re: [Ethereal-dev] New Dissector: Dumb Question
> > >
> > >
> > >
> > > > That not sounds to bad for a first try, you've looked at the usual
> > > > suspects ;-)
> > > >
> > > > So your question isn't too dumb at all...
> > >
> > > Glad to hear it... :-)
> > >
> > > > If the register.c file doesn't contain your dissector, that's the
> > > > place
> > > > to look at first. Unless you build a plugin, it has to
> > > appear in that file.
> > > >
> > > > Did you place your dissector file in epan/dissectors? It won't be
> > > > searched somewhere else.
> > >
> > > Yes, I sure did. In fact, I was basing my dissector file
> > > partially on packet-msn-messenger.c, which I've made some
> > > improvements to (I'll be submitting them once I have the last
> > > bugs worked out there). The only difference is, that file was
> > > already all registered, so I didn't have that problem there.
> > >
> > > > Does it get (re-)compiled when you change your packet-wins.c (or
> > > > whatever name you'd chosen) file? So your makefile is ok.
> > >
> > > No, there's no re-compiliation when I make changes to this file.
> > >
> > > > Did you tried simply deleting the register.c file, as it's possibly
> > > > (re-)generated?
> > >
> > > I just did this (for the second time, just to make sure), and
> > > I'm still getting no results -- while packet-wins.c is in
> > > Makefile.common in epan/dissectors, my registration function
> > > is not added to register.c.
> > >
> > > I can attach Makefiles, the source file, whatever if it would
> > > be helpful; for now I'll not spam the list. :-)
> > >
> > > Alex Kirk
> > >
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > Ethereal-dev@xxxxxxxxxxxx
> > > http://www.ethereal.com/mailman/listinfo/ether> eal-dev
> > >
> >
> >
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>