Ethereal-dev: Re: [Ethereal-dev] Re: Bug: H225 erroneously adds an all-zeros guid on some RAS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Lars Roland <lars.roland@xxxxxxx>
Date: Mon, 10 Jan 2005 03:23:29 +0100
LEGO schrieb:




The attached pacth workarrounds this behaviour avoiding to add the
hidden guid on responses when it is all zeros. Anyway I think It would
be much better to have the actual guid of the request instead, which I
believe was the original intention.
It is not a workaround. It is indeed a piece of code that got lost with the replacement of the old dissector with the automatically generated one. Thanks for digging that out. 



BTW after few hours trying to understand the mechanics of asn2eth I
got the right fix for that bug.
I am a beginner in using asn2eth, too. And I still try to figure out why I don't get a correct output of dissector's header file with cygwin's python. I'll try another win32 port of python later. 


Attached you'll find the patch to h225.cnf that actually sets
h225_pi.guid  to have the guid on responses too.


I've checked in the cnf-file.
BTW, ethereal's current h225 dissector contains support for h.450 . I don't see it in the cnf-file. 
I guess it got lost, too.

Regards,
Lars