Wireshark · Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-cvs] rev 12728: /trunk/plugins/mate/: Makefile.am Makefile.nmake ma

[LEGO <luis.ontanon@xxxxxxxxx>]

here's the patch.

- move mate_make_config into handoff
- move etts into mate_cfg_items so every pdu,gop and gog has its own


On Mon, 13 Dec 2004 02:35:36 +0100, LEGO <luis.ontanon@xxxxxxxxx> wrote:
> > ...and the plugins are initialized in the order in which
> > "readdir()"/"g_dir_read()" return them; there is *NO* absolute guarantee
> > that this order is alphabetical!
> 
> I got it, It's just a temporary workarround. I'll fix that.
> 
> > This was necessary in order to allow dissectors to register in dissector
> > tables created by other dissectors, and to get handles on other
> > dissectors.  It could also be useful for other purposes...
> 
> > ...such as doing all the work that "mate_make_config()" does.
> 
> I thought it was too late to register the hf_register_info array.
> 
> > This would, of course, mean that MATE would be registered regardless of
> > whether "mate_make_config()" succeeded, as the code in
> > "proto_register_mate()" that registers MATE wouldn't call
> > "mate_make_config()" and thus wouldn't know whether doing so would
> > succeed, but, as a London School of Economics dropout[*] once said, "you
> > can't always get what you want".
> 
> I do not realy mind not registering if not configured,  I'll get
> mate_get_pdus() to return NULL if it  is not configured it impacts
> performace a little bit but I think that wouldn't be such a big deal.
> 
> I got the config filename issue resolved.
> 
> Thanks.
> 


-- 
We can classify people in 10 categories:
- those who understand binary
- and those who don't

Attachment: mate2004123a.patch
Description: Binary data