Ethereal-dev: Re: [Ethereal-dev] show hostname in window title - feature/patch submission

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Tue, 23 Nov 2004 22:33:01 -0800
Nathan Jennings wrote:

The attached patch allows you to easily see which copy of Ethereal you're manipulating (by looking at the window title) if you have multiple Ethereal instances open on your desktop that are running on multiple machines.

If the two instances have different files open, so that the title (which shows the file name) is different in the windows, is that necessary?

I.e., should it just add the host name if it's running a capture or if it has a capture that hasn't been saved (i.e., if there's no file name)?

It doesn't handle differentiating multiple instances running on the same machine.

The file name should handle that if it has a saved file - and, otherwise, the name of the interface on which it's capturing or on which it captured, and possibly also the filter expression, might help there.

The patch also adds a user preference to show the local machine's host name in full or short format.

If we only show it when the file name is missing, is there any need to have the preference have a "don't show the host name" choice? (And should the choice be "fully-qualified domain name" vs. something else, e.g. "unqualified domain name"?

I tested it on FreeBSD 4.9-RELEASE only.

I suspect most, if not all, of the UN*Xes we support have "gethostname()". Winsock 2 has it, also, and we might require Winsock 2 (or WinPcap might require it), which I think causes a problem for Windows 95, but we *might* be able to bundle Microsoft's add-on Winsock 2 for W95, assuming that our installer can be made to install it only if necessary *and* Microsoft's license for the add-on doesn't get in the way (I think it predates their anti-GPL licenses).