Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-cvs] Rev 12522: /trunk/epan/dissectors/: packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 22 Nov 2004 01:38:49 -0800
ronnie sahlberg wrote:


Thinking things over, I am not sure that is a good approach.
It would make it difficult to get an overview which files belong to
which dissector.
For most stuff down in epan/dissectors this is easy :
to find all files related to IP we just look at packet-ip.c and packet-ip.h
And to find all stuff related to SMB we just look at packet-smb.c and smb.h... oh, and packet-smb-{browse,common,mailslot,pipe,sidsnooping}.[ch] and packet-smb-logon.c. 


These autogenerated files will consist of at least 4 and possibly 5
different files :
PROTOCOL_DEFINITION.asn
packet-PROTOCOL-template.[ch]
protocol.cnf
protocol-exp.cnf
I think it would be cleaner to keep them in their own directory protocol by protocol.
Perhaps breaking epan/dissectors up into subdirectories would be a good idea here; put each of the ASN.1-based dissectors into subdirectories of their own, and then perhaps add subdirectories for other groups of dissectors (e.g., one for SMB, as per the above). There are 713 packet-*.[ch] files in epan/dissectors; perhaps that's a bit more than should be stuffed into one directory.