Ethereal-dev: Re: [Ethereal-dev] Patch to packet-acse.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Sid Sid" <ysidelnikov@xxxxxxxxxxx>
Date: Thu, 11 Nov 2004 09:23:36 +0000
Hi,
please, have a look to attached patch which deletes those three tables and fix some strings in the others. 
Thank you.
Yuriy Sidelnikov.


BTW, packet-acse.c produces some warnings (and has done so for a while):

packet-acse.c:82: warning: `cr_vals' defined but not used
packet-acse.c:162: warning: `sequence_list_vals' defined but not used
packet-acse.c:211: warning: `type_app' defined but not used
Those are three value_string tables. Are there fields in ACSE packets that have values that are enumerated in those tables? If so, the tables should probably be used to show those values symbolically when possible. 

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev


_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.com/

Attachment: packet-acse.c.diff.txt.gz
Description: application/gzip-compressed