> -----Original Message-----
> From: ethereal-dev-bounces@xxxxxxxxxxxx [mailto:ethereal-dev-
> bounces@xxxxxxxxxxxx] On Behalf Of Guy Harris
> Sent: Sunday, October 17, 2004 4:15 PM
> To: Ethereal development
> Subject: Re: [Ethereal-dev] RTP analysis patch
>
> Alejandro Vaquero wrote:
>
> > Find attached a patch to RTP analysis to avoid RTP
packets
> > with Version != 2 (a crash if using Version 0 occurred).
>
> For some reason, the patches to packet-rtp.c and packet-rtp.h
attempted
> to replace the entire file (line-ending issues?), and didn't apply.
> Fortunately, the version being patched is the current top-of-tree SVN
> version, so I could just delete the old lines from the patch and get
rid
> of the leading "+"s and replace the source file with the result.
I have no idea what happened, I used the same editor (cygwin vi) in all
cases.
>
> The patch to rtp_analysis.c didn't have that problem.
>
> I've checked in the change.
Thanks!
>
> Is it necessary to have "rtp_packet()" ignore packets with an RTP
> version that's not 2? It looks as if the RTP dissector doesn't call
> "tap_queue_packet()" on packets other than RTP version 2 packets, so
> "rtp_packet()" should never be called with a non-RTPv2 packet.
I agree. I think we can leave it there in case someone wants to add RTP
version <>2 capabilities to packet-rtp.c.
What actually happened in my test was a fax call using T38 was
interpreted as RTP (instead of T38 along). This caused the T38 to be
dissected as RTP, getting the "Version 0". I'm working to add T38 as a
conversations when setup an SDP session to fix this.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
