Alejandro, maybe you can add some content for RTP analysis and
statistics with some nice screenshots to the wiki page?
On Sun, 3 Oct 2004 15:37:28 -0600, Alejandro Vaquero wrote:
> Hi All,
> Both gcc warnings fixed.
>
> Regards
> Alejandro
>
>
>
> -----Original Message-----
> From: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Guy Harris
> Sent: Friday, October 01, 2004 1:21 AM
> To: Ethereal development
> Subject: Re: [Ethereal-dev] RTP Graph analysis
>
> Alejandro Vaquero wrote:
>
> > Attached is a new version with the warnings fixed.
>
> Checked in.
>
> Still some warnings from GCC:
>
> rtp_analysis.c: In function `get_clock_rate':
> rtp_analysis.c:231: warning: comparison between signed and unsigned
> rtp_analysis.c: In function `rtp_packet_add_graph':
> rtp_analysis.c:441: warning: unused parameter `rtpinfo'
>
> The first of those antedates your changes - the problem is that the key
> in a key_value structure is unsigned (guint32), but -1 is used as the
> end-of-table indicator - and the comparison between the key and -1 gets
> a warning. (It also returns -1 as a "clock rate not found" value - but
> no callers check for that; they should do so.)
>
> The second warning is new - is there anything in
> "rtp_packet_add_graph()" that could, or should, use something in the
> structure pointed to by "rtpinfo"? If not, that parameter should be
> removed.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
>
>
