Ethereal-dev: Re: [Ethereal-dev] Segfault when applying a WEP key to decrypt traffic

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 25 Sep 2004 16:04:53 -0700
Joshua Wright wrote:
I'm experiencing a segfault with Ethereal from SVN as of this morning. When I apply a 40-bit WEP key and change the key index count to apply the key, Ethereal segfaults.
There's a bug in the preferences code that, when applying preference changes, can cause a packet redissection to be performed before the dissectors have been notified that their preferences have changed. This means that a dissector's internal data structures could be in an inconsistent state - in particular, the 802.11 dissector could have had its count of WEP keys increased, as that's a directly-registered preference, but it might not've been called to allocate the table of WEP keys, if necessary, and set the numerical values of those keys from the string preferences - when it's called to dissect a packet. 

I've checked in a fix.