Ethereal-dev: Re: [Ethereal-dev] [PATCH] OSCAR Dissector updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Guy Harris" <gharris@xxxxxxxxx>
Date: Thu, 16 Sep 2004 19:06:44 -0700 (PDT)
Jelmer Vernooij said:

> Here's yet another patch to the OSCAR/AIM Dissector:

Checked in.

Some warning messages:

packet-aim.c:285: warning: `aim_fnac_family_generic_redirect_tlv' defined
but not used
packet-aim.c:298: warning: `aim_snac_generic_motd_motdtypes' defined but
not used

Is there code that should be using "aim_fnac_family_generic_redirect_tlv"?

There are definitions of "aim_snac_generic_motd_motdtypes" in both
"packet-aim.c" and "packet-aim-generic.c"; they're identical, but only the
one in "packet-aim-generic.c" is used.  Should teh one in "packet-aim.c"
be removed?