Ethereal-dev: [Ethereal-dev] rtp analysis & rfc2833

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Arsen Chaloyan <achaloyan@xxxxxxxxx>
Date: Wed, 11 Aug 2004 03:48:09 -0700 (PDT)
Hello.

I want to mention two issues concerning rtp analysis
and rfc2833 (named telephone events).
Please, find the attached capture file for more
details.

1) rtp analysis shows payload type change in rtp
packets, when the stream contains both voice and
telephone events simultaneously.
This is not so correct, as the payload type doesn't
change, but the telephone events are simultaneously
transmitted.

2) rtp analysis marks rtp packets as "Wrong seq.",
while actually this is the retransmitted packets of
final event (draft-ietf-avt-rfc2833bis-04.txt).
I patched rtp_analysis.c to show this packets as
"Duplicate". 
The diff to rtp_analysis is attached. Please, commit
if it applicable.

Arsen.


	
		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage!
http://promotions.yahoo.com/new_mail 

Attachment: out_of_bound_dtmf.tgz
Description: out_of_bound_dtmf.tgz

cvs dif rtp_analysis.c 
Index: rtp_analysis.c
===================================================================
RCS file: /cvsroot/ethereal/gtk/rtp_analysis.c,v
retrieving revision 1.47
diff -r1.47 rtp_analysis.c
165a166
> #define STAT_FLAG_DUPLICATE   0x80
487,488c488,494
< 		statinfo->sequence++;
< 		statinfo->flags |= STAT_FLAG_WRONG_SEQ;
---
> 		if(statinfo->timestamp != rtpinfo->info_timestamp) {
> 			statinfo->sequence++;
> 			statinfo->flags |= STAT_FLAG_WRONG_SEQ;
> 		}
> 		else {
> 			statinfo->flags |= STAT_FLAG_DUPLICATE;
> 		}
540a547,550
> 	else if (statinfo->flags & STAT_FLAG_DUPLICATE) {
> 		g_snprintf(status,sizeof(status),"Duplicate");
> 		color = COLOR_WARNING;
> 	}