Ethereal-dev: Re: [Ethereal-dev] p2p_dir, gsm_sms, and promiscious capturing

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 9 Aug 2004 23:20:32 -0700
On Tue, Aug 10, 2004 at 06:17:10PM +1200, Bruce Fitzsimons wrote:
> I'd agree it perverts the nature of the flag. Its a relatively safe hack 
> though, in that I assume it only affects the subsequent layers for decoding?

It's safe, assuming that, once it's been set, no lower-level dissector
does anything with that flag after control is returned to it.

Passing it forward through private_data is probably cleaner (and makes
it clearer that the direction can be trusted to be known - using the
p2p_dir flag doesn't make that clear, as that flag is, in general, *not*
guaranteed to either be P2P_DIR_RECV or P2P_DIR_SENT).