Ethereal-dev: [Ethereal-dev] TDS dissector - any idea why it's not dissecting TCP/1433 by defa

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Yaniv Kaul <ykaul@xxxxxxxxxxxx>
Date: Tue, 03 Aug 2004 03:37:20 +0200
From packet-tds.c:

void
proto_reg_handoff_tds(void)
{
       /* dissector_add("tcp.port", 1433, dissect_tds,
           proto_tds); */
       heur_dissector_add("tcp", dissect_tds_tcp_heur, proto_tds);
...
It's nice that it does heuristics, but any idea why the previous line is commented? Perhaps it should be an option, to either do it on fixed ports (1433, 2433) or by heuristics? 


<rant>
Of course, I can't compile Ethereal and change it for myself on my Windows machine. 
In fact, I can't remember when was the last time I could...
Right now the problem is:
NMAKE : fatal error U1073: don't know how to make 'adler32.obj'
I wonder if we could add to the check-in process a successful compilation test, and reject check-ins that fail it 
</rant>

Y.