Ethereal-dev: Re: [Ethereal-dev] Saving the contents of the TCP follow dialog without formatti

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sat, 24 Jul 2004 08:04:40 +0200
Alan Jenkins wrote:


I tried the patch.

When I started testing, I realized that if I click on any of the radio
buttons, it will not return from changing the content.

The follow_charset_toggle_cb() function seems to be running endlessly.

I didn't do any further debugging, could you please double check your
patch?
I'm afraid I can't reproduce or explain this. I expect it gets stuck in follow_read_stream ().
The conversion can take a while - obviouslly it depends on the length of the stream and the type of conversion. The only effect on this my patch should have had is to increase the conversion time for ASCII (it will now do the non-printable-characters conversion twice). If the conversion doesn't finish in the time it used to, then there is definitely a problem.
I am suprised that such a problem exists, since the only code which I added relates to postsript printing - the rest is just a rehash of what was already there.
As the first display always works, and pressing one of the radio buttons doesn't return, there must be some bug in it somewhere.
Pressing one of the radio button won't take very much longer than doing the same thing the first time, I would guess.
I currently don't have the time to look deeper into it, maybe I will have a look on monday. 

Regards, ULFL