Ethereal-dev: RE: [Ethereal-dev] [PATCH] Fields for PDU types in COTP packet-cl np.patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: matthew.bradley@xxxxxxxxxxxxx
Date: Thu, 1 Jul 2004 10:08:10 +0100
Yes, you're right. Ignore the patch.


> -----Original Message-----
> From: Guy Harris [mailto:gharris@xxxxxxxxx]
> Sent: 01 July 2004 09:42
> To: Ethereal development
> Subject: Re: [Ethereal-dev] [PATCH] Fields for PDU types in COTP
> packet-clnp.patch
> 
> 
> On Thu, Jul 01, 2004 at 09:31:10AM +0100, 
> matthew.bradley@xxxxxxxxxxxxx wrote:
> > Please find attached a patch against the latest 
> packet-clnp.c. If adds
> > fields for cotp.type.XX where XX is the TPDU type: CR, CC, 
> AK, DT etc. This
> > allows easy filtering and searching.
> > 
> > The patch sets the field type for the TPDU type fields to FT_NONE.
> 
> Why?  That's the wrong type for something that you want to 
> filter on, as
> it doesn't have a value assigned to it.
> 
> Does filtering on
> 
> 	cotp.type == CR
> 
> not find packets of type CR?  If it does, why is cotp.type.CR needed
> (other than saving 3 characters in the filter expression - you can
> reduce that to one character with
> 
> 	cotp.type==CR
> 
> )?  If it doesn't, that's a bug.
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
> 


Community Network Services Ltd..
204-207 Western Docks, Southampton, Hants. SO15 1DA
Switchboard : +44 (0)845 6589920 Fax : +44 (0)2380 799602
Help Desk : +44 (0)845 6589930
http://www.cnsonline.net/
Reg. no. 2084279 England
*************************************************************
All views or opinions expressed herein are solely 
those of the author and do not necessarily represent those  
of Community Network Services Ltd who do not accept 
liability for any action taken in reliance on the contents 
of this message (other than where the company has a legal 
or regulatory obligation to do so) or for the consequences 
of any computer viruses which may have been transmitted 
by this E-Mail
The E-Mail and any files transmitted  with it, are confidential 
and intended solely for the use of the individual or entity to 
whom they are addressed. If you have received this message 
in error please notify the sender and delete the message 
immediately or alternatively email postmaster@xxxxxxxxxxxxx
***************************************************************