Ethereal-dev: Re: [Ethereal-dev] reproducible crash in Ethereal (latest CVS)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 28 Jun 2004 23:50:04 -0700
On Mon, Jun 28, 2004 at 10:51:09AM -0700, Guy Harris wrote:
> ...and the code should do something more useful than crash if that
> configuration appears in the configuration file as a result of being put
> in there by hand, i.e. it shouldn't trust the value from the configuration
> file, it should check it and, if it's not one of the valid values, ignore
> the value from the configuration file and use the default value.

I've checked in a change to do that.

Perhaps it should report the invalid value as an error, but the prefs
code currently doesn't have a mechanism to report errors other than
"syntax error" (which an invalid value wouldn't be, it's just an
out-of-range number), "no such preference" (but there *is* such a
preference), or "preference was in older releases but not this one
(again, not so).  That should probably be fixed at some point.

BTW, should we provide symbolic names for the layout types?  The hard
part is coming up with someting reasonable descriptive but shorter than
"the layout with the packet list on the left and the packet detail and
hex dump on the right, with the packet detail above the hex dump", etc..