Ethereal-dev: Re: [Ethereal-dev] OSPF-TE patch for GMPLS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 19 Jun 2004 02:53:29 -0700
On Fri, Jun 18, 2004 at 05:05:12PM +0200, Carles Kishimoto wrote:
> I've made some modifications in the CVS ethereal version in order to get
> support for GMPLS extensions draft:
> 	draft-ietf-ccamp-ospf-gmpls-extensions-12.txt.
> A patch is attached.

Checked in.

Is there some reason why "gmpls_protection_cap_str[]" is defined in
"packet-rsvp.c", as the RSVP dissector doesn't use it? 
"gmpls_switching_type_str[]" and "gmpls_lsp_enc_str[]" are used both in
the RSVP dissector and other dissectors, so it makes sense to define
them in one of the dissector source files and export them to others,
but, if "gmpls_protection_cap_str[]" is used only in the OSPF dissector,
it should perhaps be defined there.