Ethereal-dev: Re: [Ethereal-dev] warnings in latest CVS packet-kerberos.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Tue, 15 Jun 2004 02:53:45 -0700
On Tue, Jun 15, 2004 at 11:07:51AM +0200, Jean-Baptiste Marchand wrote:
> the attached diff should fix the problem (based on the following
> definitions in ntsecapi.h):

	...

> #define KERB_ETYPE_RC4_PLAIN2       -129

	...

> +#define KRB5_ENCTYPE_RC4_PLAIN2		0xffffff7f

Should "dissect_ber_integer()" take a "gint32 *" as an argument, and
should the encryption types (and perhaps other items) be "gint32"s
rather than "guint32"s, and should the matching
"proto_item_append_text()" calls use "%d" as the format?  (Perhaps there
should be "dissect_ber_unsigned_integer()" for cases of numbers that use
a similar encoding to BER integers but that are unsigned.)