Ethereal-dev: RE: [PATCH] packet-snmp.c (was: Re: [Ethereal-dev] dissector port clash(e.g. SNM
Sounds promising.
I just wanted to state that I believe that although some dissectors may
decode packets as something they are not, as long as the user has some
control over this behaviour that it isn't all that bad, as usually you have
some idea of what is meant to be going on. Eg if you are expecting RTP
streams you would like to see them as RTP, and if you are not expecting
them, and they do not decode correctly, then turn off the dissector.
Regards
Grant
-----Original Message-----
Thomas Anders wrote:
> Martin Regner wrote:
>
>> One way of solving this particular problem could maybe be to add a
>> preference setting in SNMP
>> dissector that specifies if it should start up a conversation.
>
> I had exactly the same idea, especially since most real-world SNMP
> traffic (as in the sample capture) actually either goes to or from
> one of the well-known ports (161,162), so the conversation code
> just introduces problems instead of benefits. What I'm wondering
> is if we should rather solve this individually per dissector or more
> generally, given that a dozen dissectors seem to use similar code
> here.
Following up myself, the attached patch for packet-snmp.c implements
a new preference setting that decides whether to start a conversation.
Default is true for backward compatibility.
Works for me. Please review and apply. (Feel free to check in with
a better preference setting description.)
On a related note, the thread
http://www.ethereal.com/lists/ethereal-dev/200404/msg00283.html
looks extremely relevant, but unfortunately has stopped.
+Thomas
--
Thomas Anders (thomas.anders at blue-cable.de)
