Ethereal-dev: Re: [Ethereal-dev] patch for packet-bacnet.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 12 May 2004 12:57:00 -0700
On Wed, May 12, 2004 at 08:48:42PM +0200, Herbert Lischka wrote:
> made some minor changes to packet-bacnet.c just to give packet-bacapp.c
> the chance to display the info field correctly
> 
> if (!tree) calculate offset to start with apdu at the end of npdu

Unfortunately, that duplicates code - I've changed it to do all the work
regardless of whether "tree" is null or not; that adds some CPU time to
dissections that aren't building the protocol tree (such as the
dissection done when the capture is read in, at least if you're not
coloring packets), but hopefully it won't add too much CPU time.

I also cleaned up some other stuff that I noticed.