Ethereal-dev: Re: [Ethereal-dev] Bug in DICOM dissector - fixed

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Sat, 8 May 2004 23:35:45 +0200
Checked in.

(The easiest is to send patches as unified diffs only (you don't need
to send the updated file together with the patch). If you have CVS
access, a mere "cvs diff -u <file> > cvs.diff" will do if you send the
cvs.diff in attachment to the mail.)

Regards,

Olivier

----- Original Message ----- 
From: Richard Coe


| Thanks Olivier.
|
| This change reverts it back to only create the conversation on the
| first packet of a DICOM conversation.
|
| Included is the diff, and the new file.
|
| "Olivier Biot" writes:
| In a message dated: Sat, 08 May 2004 15:47:02 +0200
| > Hi list,
| >
| > The DICOM dissector only checked whether a conversation did not
exist.
| > If a conversation already existed for another protocol, the DICOM
| > dissector would assume it was a DICOM conversation.
| >
| > I checked in a fix so existing conversations not pertaining to
DICOM
| > are skipped. As I have no DICOM captures, I cannot test whether it
is
| > now 100% fixed.