Wireshark · Ethereal-dev: RE: [Ethereal-dev] HTTP gzip/deflate decompression patch - zlib a nd gzip on Win32

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

|From: Jerry Talkington
|
|On Thu, May 06, 2004 at 11:12:31PM +0200, Olivier Biot wrote:
|
|> One last remark: I've noticed that you don't provide access to
|> the uncompressed data. Maybe we can provide a subtree item in
|> the HTTP tree
|>(I'd like to have some comments from other fellows here).
|
|In which case is it not available?  If the data is passed to a
|subdissector, clicking on that subdissector's subtree selects 
|all of the
|uncompressed data.  If there is no subdissector, it should be
|displayed as "data."

That's correct, however you cannot select the gzip compressed body,
you can only select the *uncompressed* bytes. So it would be nice
if it were possible to have an item in the HTTP protocol tree
where an end-user has the possibility to click on the compressed
body, and optionally on the uncompressed body if uncompression
succeeded (implying HAVE_ZLIB was true at compile time, of course).

I think that portion of the code is about line 693 of packet-http.c.

I'd also suggest to replace "Entity body" with "Uncompressed entity
body" or "Compressed entity body", or replace "compressed" with
"decoded" in the add_new_data_source calls. This way it is clearer
to the end-user that the data is (un)compressed.

Regards,

Olivier