Ethereal-dev: Re: [Ethereal-dev] Patch for CLNS over Cisco HDLC dissecting

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Carlos M. Pignataro" <cpignata@xxxxxxxxx>
Date: Sat, 01 May 2004 23:38:49 -0400
At 02:26 PM 5/1/2004 -0700, Guy Harris wrote:
>On Fri, Apr 30, 2004 at 09:03:04AM -0400, Carlos M. Pignataro wrote:
>> Please find attached diffs to packet-chdlc.c for:
>> o Fix dissecting of CLNS Protocols over Cisco HDLC
>> 
>> Comments and corrections are most welcome.
>
>Should that be done by modifying the Cisco HDLC dissector, or should it
>be done by having a "CLNS-over-CHDLC" dissector that puts the pad byte
>into its protocol tree - or just skips over it and calls the OSI
>dissector?

Thanks for the comment.
I suppose it's a matter of point of view or perception, as to where the padding byte "belongs" to. It doesn't belong in OSI header and it's not a "protocol layer" between C-HDLC and CLNS. My understanding and underlying assumption in the original diffs is that the padding byte is part of the C-HDLC header, and that's why I modified the Cisco HDLC dissector. If the CHDLC Protocol is 0xfefe, then the c-hdlc header includes a padding byte. Were you thinking of something like any of the attached?

I think this padding byte would be more accurate and clear as part of the CHDLC dissector (like in the original diffs), but have no strong thoughts either way.

Thanks,

--Carlos.


>_______________________________________________
>Ethereal-dev mailing list
>Ethereal-dev@xxxxxxxxxxxx
>http://www.ethereal.com/mailman/listinfo/ethereal-dev

Attachment: packet-osi.c.patch
Description: Binary data

Attachment: packet-osi.c.2.patch
Description: Binary data