Ethereal-dev: RE: [Ethereal-dev] [PATCH] SIP hidden fields for finding errors ( take 2)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Biot Olivier <Olivier.Biot@xxxxxxxxxxx>
Date: Mon, 19 Apr 2004 15:59:29 +0200
|-----Original Message-----
|From: Martin Mathieson
|
|Thanks guys for the comments, this version has the following 
|improvements:
|
|- The fields now visibly appear as booleans under the 
|request/response tree
|(as Biot suggested)
|- The test for error responses is now >= 400
|- Check for trees being null before adding proto items
|- Removed the preference setting as the memchunks *can* grow 
|thenselves.
|Decreased initial sizes of chunks to 50
|
|I resisted the temptation to change the response code from a 
|string to a
|number (which would make filtering easier)...
|
|>From RFC 3261, section 7.1:
|
|"Unlike HTTP/1.1, SIP treats the version number as a literal
|           string.  In practice, this should make no difference."

That portion refers to the SIP *version identifier*, not the *status code*
itself. Section 7.2 of SIP 2.0 (RFC3261) says that the 'Status-Code' is a
3-digit integer result code (see section 21 for result code meanings).

I would definitely make a integer *status code* but would keep the *version*
a text string (some SIP implementations use non-numeric version identifiers;
there's a SIP preference to stop "strict enforcement" of SIP version to
"SIP/2.0").

Regards,

Olivier