Ethereal-dev: RE: [Ethereal-dev] SIP: selected packet bytes (resend with patch attached)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Anders Broman (AL/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Thu, 19 Feb 2004 10:46:23 +0100
Hi,
My reasoning is that SDP is part of the SIP/BICC(not ISUP ):)/MEGACO message and not an entity of it's own.
Best regards
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Guy Harris
Sent: den 19 februari 2004 10:42
To: Ethereal development
Subject: Re: [Ethereal-dev] SIP: selected packet bytes (resend with
patch attached)


On Thu, Feb 19, 2004 at 10:18:48AM +0100, Joerg Mayer wrote:
> I'd like to keep sdp at the top level. Is there a reason why some of the
> other protocols don't put it there?

In the case of SIP, it's apparently because Anders Broman didn't want it
there:

	% cvs log packet-sip.c

		...

	revision 1.50
	date: 2003/12/08 20:25:31;  author: guy;  state: Exp;  lines: +224 -170
	From Anders Broman:

	        Call subdissectors regardless of whether we're building a
	        protocol tree or not.

	        Use the "media_type" dissector table to hand off to
	        subdissectors, rather than wiring in SDP.

	        Put the message body into a subtree of the SIP tree rather than
	        at the top level.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev

This communication is confidential and intended solely for the addressee(s). Any unauthorized review, use, disclosure or distribution is prohibited. If you believe this message has been sent to you in error, please notify the sender by replying to this transmission and delete the message without disclosing it. Thank you.

E-mail including attachments is susceptible to data corruption, interruption, unauthorized amendment, tampering and viruses, and we only send and receive e-mails on the basis that we are not liable for any such corruption, interception, amendment, tampering or viruses or any consequences thereof.