Ethereal-dev: Re: [Ethereal-dev] patch to packet-dcerpc.c - to show interface names - win32 on

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sun, 15 Feb 2004 10:37:11 +0100
On Sun, Feb 15, 2004 at 10:14:25AM +0200, Yaniv Kaul wrote:
> For some reason, my previous patch didn't make it into CVS (due to an 
> innocent C++ style comment, perhaps).

Maybe, or maybe erveryone was busy and missed your patch.
Or maybe, your patch is going to create quite a few warnings on
non-windows systems because of unused variables and parameters.
Or maybe, I don't understand why it is valid to use resources
from the local machine to decode theses values which were passed
between two other machines. Maybe, if this is a valid aproach,
these values are globally constant and should be copied into
Ethereal to make them available to all os.
Or maybe I'm just too tired to think clearly anymore.

  Jörg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.