Ethereal-dev: Re: [Ethereal-dev] SoulSeek Dissector breaks MSVC build

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Kendy Kutzner <kutzner@xxxxxxxxx>
Date: Fri, 13 Feb 2004 08:45:03 +0100
On 2004-02-12T13:01:46-0800, Guy Harris wrote:
> Checked in, with a change to use "tvb_memdup()" to make a copy of the 
> compressed data (so that, if not all the data is present, an exception 
> is thrown before anything is allocated).
> 
> Is that copy required?

On x86, IMHO it isn't. On other platforms, I'm not sure. Pointer
alignment? Byte ordering? Are the tvb guaranteed to be
contiguous?

> The "zlib.h" in Mac OS 10.3, at least, says
> 
> 	ZEXTERN int ZEXPORT uncompress OF((Bytef *dest,   uLongf *destLen,
> 	                                   const Bytef *source, uLong 
> sourceLen));
> 
> which suggests that the compressed data isn't modified;

same here (x86/Linux)

Kendy

--

Attachment: pgp7TYQ9TvwBm.pgp
Description: PGP signature