Ethereal-dev: [Ethereal-dev] packet-http.c bug or typo?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: didier <dgautheron@xxxxxxxx>
Date: Wed, 11 Feb 2004 07:00:43 +0000
Hi,
Can you double check packet-http.c around line 854.
                if (isHttpRequestOrReply && req_dissector) {
                        if (!stat_info->request_method)
stat_info->request_method = g_malloc( index+1 ); strncpy( stat_info->request_method, data, index); 
                                stat_info->request_method[index] = '\0';
                }
it's
                if (isHttpRequestOrReply && req_dissector) {
                        if (!stat_info->request_method) {
stat_info->request_method = g_malloc( index+1 ); strncpy( stat_info->request_method, data, index); 
                                stat_info->request_method[index] = '\0';
			}
                }
or
                if (isHttpRequestOrReply && req_dissector) {
                        if (!stat_info->request_method) {
stat_info->request_method = g_malloc( index+1 ); 
			}
                        strncpy( stat_info->request_method, data, index);
                        stat_info->request_method[index] = '\0';
                }

Didier