Wireshark · Ethereal-dev: Re: [Ethereal-dev] -pedantic

[Michael Tuexen <Michael.Tuexen@xxxxxxxxxxxxxxxxx>]

Hi Jörg,

I'm using glib 1.2.10 and I see a lot of warnings coming from
glib.h.

So I would like to prefer to have it switchable like it is
in the top directory.

If you want to get rid of some warning you can use configure
to enable the additional gcc checks.

This is an example of the output I see (the glib.h stuff is
repeated many times):

source='airopeek9.c' object='airopeek9.o' libtool=no \
depfile='.deps/airopeek9.Po' tmpdepfile='.deps/airopeek9.TPo' \
depmode=gcc3 /bin/sh ./../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I.   -I/usr/local/include 
-I/usr/local/include  -no-cpp-precomp -D_U_="__attribute__((unused))" 
-Wall -W -Wcast-qual -Wcast-align -Wbad-function-cast -pedantic -g -O2 
-I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include 
-I/usr/local/include -I/usr/local/include -c `test -f 'airopeek9.c' || 
echo './'`airopeek9.c
In file included from wtap-int.h:30,
                 from airopeek9.c:30:
/usr/local/include/glib-1.2/glib.h:1308:23: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1311:25: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1314:26: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1317:25: warning: ISO C does not 
permit named variadic macros
airopeek9.c: In function `airopeek9_open':
airopeek9.c:192: warning: ISO C forbids braced-groups within expressions
airopeek9.c: In function `airopeekv9_read':
airopeek9.c:503: warning: ISO C forbids braced-groups within expressions
airopeek9.c: In function `airopeekv9_seek_read':
airopeek9.c:586: warning: ISO C forbids braced-groups within expressions
source='ascend-grammar.c' object='ascend-grammar.o' libtool=no \
depfile='.deps/ascend-grammar.Po' tmpdepfile='.deps/ascend-grammar.TPo' 
\
depmode=gcc3 /bin/sh ./../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I.   -I/usr/local/include 
-I/usr/local/include  -no-cpp-precomp -D_U_="__attribute__((unused))" 
-Wall -W -Wcast-qual -Wcast-align -Wbad-function-cast -pedantic -g -O2 
-I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include 
-I/usr/local/include -I/usr/local/include -c `test -f 
'ascend-grammar.c' || echo './'`ascend-grammar.c
In file included from wtap-int.h:30,
                 from ascend-grammar.y:113:
/usr/local/include/glib-1.2/glib.h:1308:23: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1311:25: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1314:26: warning: ISO C does not 
permit named variadic macros
/usr/local/include/glib-1.2/glib.h:1317:25: warning: ISO C does not 
permit named variadic macros
source='ascend-scanner.c' object='ascend-scanner.o' libtool=no \
depfile='.deps/ascend-scanner.Po' tmpdepfile='.deps/ascend-scanner.TPo' 
\
depmode=gcc3 /bin/sh ./../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I.   -I/usr/local/include 
-I/usr/local/include  -no




Best regards
Michael

On 8. Feb 2004, at 1:52 Uhr, Joerg Mayer wrote:

> On Sat, Feb 07, 2004 at 02:52:41PM +0100, Michael Tuexen wrote:
> > It seems for me, that you are using -pedantic, iff gcc is the 
> > compiler.
> >
> > Why are you not using the same as the top level?
>
> The reason is, that almost all additional warnings that occurred in
> epan and wiretap have been fixed, and that it is noticably less work
> when the people who work on a file get things "right" immediately.
> The -pedantic will have to go back into the extra warnings once
> libethereal contains the dissection stuff.
>
> I guess you are asking this question for a specific reason. Are you
> seeing lots of additional warnings? If so, which ones and how many?
> In case we cannot reasonably get rid of most of them, then yes, things
> should be done as they were done before I move the -pedantic stuff.
> It's just that I'd like to read about the specific reasons :)
>
>  ciao
>         Jörg
> --
> Joerg Mayer                                           
> <jmayer@xxxxxxxxx>
> We are stuck with technology when what we really want is just stuff 
> that
> works. Some say that should read Microsoft instead of technology.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev