Ethereal-dev: Re: [Ethereal-dev] Core dump in current gsm-sms-ud dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Tue, 27 Jan 2004 18:17:58 +0100
From: "Chris Wilson"

| Hi Olivier,
|
| > Current "gsm-sms-ud" dissector causes a crash on a reference
capture I
| > have(funny it didn't crash yesterday when I committed a SMPP
patch). I
| > think the gsm-sms-ud protocol registration is the cause (handle =
0x0).
| > As I don't have the time right now, could someone else have a
look?
|
| This is my fault, missed a bit whilst pulling GSM SMS UD from the
| SMPP code. You'll only see that problem if you have the option to
| pass all UDH with a port onto the WSP dissector

Correct.

| (aside: shouldn't that option be in the WSP dissector?)

That option relates to GSM SMS User Data containing a
Ports IE with 16-bit ports. The WSP dissector does not
know about an UDH.

| Fix is:
|
| RCS file: /cvsroot/ethereal/packet-gsm_sms_ud.c,v
| retrieving revision 1.3
| diff -r1.3 packet-gsm_sms_ud.c
| 613a627,629
| >
| >       wsp_handle = find_dissector("wsp-cl");
| >       g_assert (wsp_handle);

Checked in, along with the removal of the email address as suggested
by today's postings.

Regards,

Olivier