Ethereal-dev: RE: [Ethereal-dev] Use of tcp_dissect_pdu and tvb_format_text

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman (TN/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Fri, 23 Jan 2004 10:21:22 +0100
Hi,
Is there any reason why the preference to let sub dissectors do TCP reasembly shouldn't be default on ?
As this seems to be a very common "misstake" to make.
Best regards
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Guy Harris
Sent: den 23 januari 2004 10:12
To: CNS - Matthew Bradley
Cc: Ethereal Dev (ethereal-dev@xxxxxxxxxxxx)
Subject: Re: [Ethereal-dev] Use of tcp_dissect_pdu and tvb_format_text


On Fri, Jan 23, 2004 at 08:48:38AM -0000, CNS - Matthew Bradley wrote:
> Matthew: No, when I wrote the email but I stumbled across this before
> receiving your message. Can we add something to this effect to the
> README.developer section about tcp_dissect_pdus.

It's an issue for *all* TCP dissectors that do reassembly, even if they
don't use "tcp_dissect_pdus()".

It might also belong as a FAQ, as users not writing dissectors also run
across it.

> Now if I turn off the "Allow subdissector to desegment TCP streams"
> preference for TCP?, I get my "Short Frame" error. How can I check if this
> preference is set?

You can't.  If the user turns that option off, reassembly won't be done
- which is as it should be.  The error shouldn't be "Short Frame"; that
happens on some occasions, not all of which are, I think, associated
with TCP reassembly.  Part of the problem might, I think, be due to
requiring multiple lengths for tvbuffs, such as "size the packet would
have been had it been reassembled".

> Tvb_reported_length_Remaining still returns the reassembled length.

Given that reassembly isn't being done, that would be a bug.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev