Wireshark · Ethereal-dev: Re: [Ethereal-dev] PATCH: RTP Analysis: refresh, column sort, ...

["Olivier Biot" <ethereal@xxxxxxxxxx>]

Hi Lars,

If I apply your patch and compile it with Gtk+ 2.0, then gcc generates
errors:

gcc -DHAVE_CONFIG_H -I. -I. -I..  -I.. -I../wiretap -I/usr/local/inclu
de  -D_U_="__attribute__((unused))" -Wall -W -Wcast-qual -Wcast-align 
-Wbad-function-cast -pedantic -Wstrict-prototypes -O3 -ggdb -I/usr/loc
al/include -pthreads -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk
-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/X1
1R6/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -c
rtp_analysis.c
gcc: unrecognized option `-pthreads'
In file included from /usr/X11R6/include/gtk-2.0/gtk/gtk.h:90,
                 from rtp_stream_dlg.h:31,
                 from rtp_analysis.c:41:
/usr/X11R6/include/gtk-2.0/gtk/gtkitemfactory.h:51: warning: function
declaration isn't a prototype
rtp_analysis.c: In function `on_goto_bt_clicked':
rtp_analysis.c:786: warning: cast does not match function type
rtp_analysis.c: In function `on_refresh_bt_clicked':
rtp_analysis.c:826: warning: ISO C forbids passing arg 4 of
`register_tap_listener' between function pointer and `void *'
rtp_analysis.c:826: warning: ISO C forbids passing arg 5 of
`register_tap_listener' between function pointer and `void *'
rtp_analysis.c:826: warning: ISO C forbids passing arg 6 of
`register_tap_listener' between function pointer and `void *'
rtp_analysis.c: In function `copy_file':
rtp_analysis.c:1121: warning: passing arg 3 of `create_progress_dlg'
from incompatible pointer type
rtp_analysis.c:1121: error: too many arguments to function
`create_progress_dlg'
rtp_analysis.c: In function `rtp_sort_column':
rtp_analysis.c:1609: warning: cast discards qualifiers from pointer
target type
rtp_analysis.c:1610: warning: cast discards qualifiers from pointer
target type
rtp_analysis.c: In function `add_sort_by_column':
rtp_analysis.c:1717: warning: unused parameter `user_data'
rtp_analysis.c: In function `create_rtp_dialog':
rtp_analysis.c:1781: warning: unused variable `titles'
rtp_analysis.c: In function `process_node':
rtp_analysis.c:1968: warning: cast discards qualifiers from pointer
target type
rtp_analysis.c: In function `get_int_value_from_proto_tree':
rtp_analysis.c:2005: warning: cast discards qualifiers from pointer
target type
make: *** [rtp_analysis.o] Error 1

Regards,

Olivier
----- Original Message ----- 
From: "Lars Ruoff"

| PATCH for rtp_analysis:
|
| - "Refresh" button is back again. Everything should work fine now
with
| multiple windows on the same streams.
| - made packet list sortable by column.
| - show a warning when user chooses "RTP Streams/Analyze" without
having a
| RTP packet selected instead of displaying the streams box.
| - minor GUI updates, renamed button "Next" to "Next non-Ok" for more
| clarity.
|
| please check-in.
| Lars Ruoff