Wireshark · Ethereal-dev: [Ethereal-dev] Solution proposal for layout problem of "bottom button row" differences between GTK1

[Ulf Lamping <ulf.lamping@xxxxxx>]

Hi List!

As discussed earlier on this list, there is a difference in the layout 
of the standard dialog "bottom button row",
caused by different styleguide suggestions for GTK1 and 2 I think.


Two things on this topic, which should be solved:

a.) GTK 1 / 2 differences
Example, when having "OK" and "Cancel" buttons in a dialog:
In GTK1, the "OK" button will be left and the "Cancel" button will be right
In GTK2 the "OK" button will be *right* and the "Cancel" button will be 
*left*

b.) various button layouts for the same buttons
While working on the stock icons, I realized that the layout of the 
button row is a lot different for different dialogs.
E.g.: Sometimes a single "Close" button is in the middle of the dialog 
(IMHO ok), but sometimes on the right.


Proposal to solve both:
Implement a new function which will get a list of (named?) buttons to 
display, and returns a widget including this buttons.

This will solve:
a.) the GTK1 / 2 difference, as the layout can be switched at a central 
point
b.) different layouts for the same button "pile", as the function can 
decide how the buttons should be layouted


I have to think about a simple and effective parameter profile for this 
new function.

This might not be a solution for really all dialogs (as some of the 
statistics dialogs have *very* different buttons),
but should be a good step in the right direction.

Any comments on this?

Regards, ULFL