Ethereal-dev: RE: [Ethereal-dev] Bugfix packet-isup.c - Location number(patch)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman (TN/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Wed, 14 Jan 2004 18:25:38 +0100
Hi,
Included fixes to parameters:
Access transport
User teleservice info
User service info prime
Echo control information

To decode Access transport packet-q931 must export a routine which can dissect
q.931 info elements -patch to supply such a function included.

I haven't fixed display information as I don't have an example frame.
Best regards
Anders Broman

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Guy Harris
Sent: den 14 januari 2004 00:07
To: Anders Broman
Cc: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] Bugfix packet-isup.c - Location
number(patch)



On Jan 13, 2004, at 1:28 PM, Anders Broman wrote:

> Found an error with location number ifaddress presentation restricted 
> indicator indicates address not available.
>
> Included a patch where application/isup string is changed to lower 
> case as well.

Checked in.

> Also included a sample frame.

That frame has a User teleservices parameter with a length of 2, not 3; 
I changed the length #define for that parameter to 2, and changed the 
code to handle it to use the length of the tvbuff as the parameter 
length.

That parameter, along with the access transport parameter, user service 
information prime parameter, and display information parameter are 
apparently defined in Q.931 but the ISUP dissector doesn't call any 
Q.931 dissector routine to handle them.  Does the Q.931 dissector have 
routines for them?  If so, they should probably be exported from the 
Q.931 dissector and called by the ISUP dissector.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev

Attachment: q931.diff
Description: Binary data

Attachment: q931.h.diff
Description: Binary data

Attachment: isup.diff
Description: Binary data