Wireshark · Ethereal-dev: [Ethereal-dev] RFQ - common display filter object

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

Hi list,

Currently we're keeping track of many filters and filter_related data as
global variables. I'd like to propose the following changes for display
filters:

1. Use a common struct for all display filters, keeping track
   of possible coloring and packet count.

2. Store the display filter objects in two linked lists:
      - One for active display filters,
      - One for unused display filters (e.g., a deleted color filter)
   We can get rid of the latter once we close or reload a file.

The reason for the unused display filter list is that an user may have a
colorized packet list and then the user edits its color filter list,
removing one entry. If we free this entry, the pointers to the now unused
color filter are not OK anymore.

We can get rid of an unused display filter object once we reprocess, close
or reload a file. We probably have to distinguish between tap display
filters, color filters and "the" display filter.

Regards,

Olivier