Ethereal-dev: [Ethereal-dev] Fixing the "no coloring after unmarking" bug

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Fri, 9 Jan 2004 00:47:00 +0100
Hi list,

I'm trying to fix the very old and well-known "no coloring after unmarking"
bug. A quick look at main.c yields the starting point: set_frame_mark()
which uses NULL color_t structs when we unmark a frame. Is it acceptable to
store the color filter colors in the frame_data structure when we apply the
color filters? This way, toggling between marked and unmarked can easily be
implemented as the colors are stored.

An additional advantage of storing those colors is that we could print
packet summaries in color (e.g., in HTML format).

Regards,

Olivier