Ethereal-dev: [Ethereal-dev] Warnings in packet-h245.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 7 Jan 2004 23:25:32 +0100
I get the following warnings in packet-h245.c:

packet-h245.c:13932: warning: invalid storage class for function `dissect_h245_RedundancyEncodingElement'
packet-h245.c:13945: warning: invalid storage class for function `dissect_h245_MultiplePayloadStreamElement'
packet-h245.c:13958: warning: invalid storage class for function `dissect_h245_RedundancyEncodingDTModeElement'
packet-h245.c:13971: warning: invalid storage class for function `dissect_h245_MultiplePayloadStreamElementMode'

one of the places looks like this:

static int
dissect_h245_secondary_REE_sequence_of(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree)
{
  /* XXX */
  static int dissect_h245_RedundancyEncodingElement(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree);

          offset=dissect_per_sequence_of(tvb, offset, pinfo, tree, hf_h245_secondary_REE, ett_h245_secondary_REE, dissect_h245_RedundancyEncodingElement );
                  return offset;
}

Is there a reason why the forward declaration is done inside the function
instead of outside (I just tried and it seems to work fine).
Also, why the XXX?

Thanks
    Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.