Wireshark · Ethereal-dev: Re: [Ethereal-dev] Diasbled Protocols dialog box and extra rescans ...

[Richard Sharpe <rsharpe@xxxxxxxxxxxxxxxxx>]

On Sun, 4 Jan 2004, Guy Harris wrote:

> On Sun, Jan 04, 2004 at 04:56:12PM -0800, Richard Sharpe wrote:
> > if you bring up the Diabled Protocols dialog box, toggle the status of a 
> > protocol, and then click Save, Ethereal will then rescan the capture file. 
> > This seems reasonable.
> > 
> > If you then click on the X button on the decoration to destroy the window, 
> > Ethereal will do another rescan.
> 
> Currently, requesting that the window be deleted (e.g., clicking on the
> "X" button on Windows and in many X window managers) the window is
> equivalent to clicking "Cancel".

Yes, I noticed that when I looked at the code ...

If you click cancel, the code tries to revert any changes you have made, 
however, it was not clear to me that would happen if you did the 
following:

S1: Open the Enabled Protocols... dialog box

  Make changes C1

S2: Click Save

  Make changes C2

S3: Click Cancel or the X

What is the state of the enabled protocols now? S1 or S2? If S1, then what 
is the state of the enabled protocols in the disabled_protocols file?

There seems to be no code to revert the state of the disabled_protocols 
file if you click Cancel etc.

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com