| From: Michael Shuldman
|
| Biot Olivier wrote,
| >
| > If the X11 protocol needs to export functionality to other parts of
| > Ethereal, then packet-x11.h makes sense; if it only
| contains declarations
| > static to X11 then it doesn't.
|
| It only contains stuff relevant to X11, I take it you mean
| you don't want another extra file and want to put it into a
| previously existing file?
I'll paste the contents of the header file in packet-x11.c.
| > I suppose the file keysymdef.h is a modified version of the
| > packet-x11-keysym.h file.
|
| Mmm, actually no. I suppose they could well be merged
| together though,
| since the contents is related.
OK. I propose to rename it to "packet-x11-keysymdef.c" so we keep some
consistency in file naming.
|
| > Another quick look at the differences between existing and
| new X11 dissector
| > shows that some macros don't expand to expressions within
| curly braces
| > anymore. I suppose this was intentional.
|
| Yes, I wanted the value too, not just set the variable.
|
|
| > I at least need your packet-x11.h file (and preferably also
| your keysymdef.h
| > file) in order to compile Ethereal.
|
| Weren't they included in my mail? According to my mailfolder, I
| sent the following files:
Silly me :) I was only looking at your last mail, but I forgot to look at
the big one :)))
Regards,
Olivier
