Wireshark · Ethereal-dev: RE: [Ethereal-dev] support for X11 replies and events

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

| From: Michael Shuldman
| 
| Biot Olivier wrote,
| > Could you tell me which Ethereal version you patched the 
| X11 dissector?
| 
| This was for the last (?) version, ethereal-0.10.0a.

Strange, as the RCS identifier and the includes of the packet-x11.c you sent
are different:

/*
 * $Id: packet-x11.c,v 1.11 2003/12/29 13:30:57 michaels Exp michaels $
 */
#include "packet-x11.h"
#include "keysymdef.h"

[I suppose you're working on a private CVS repository based on current
Ethereal, and that this is version 1.11 within your *private* repository.]

If the X11 protocol needs to export functionality to other parts of
Ethereal, then packet-x11.h makes sense; if it only contains declarations
static to X11 then it doesn't.

I suppose the file keysymdef.h is a modified version of the
packet-x11-keysym.h file.

Another quick look at the differences between existing and new X11 dissector
shows that some macros don't expand to expressions within curly braces
anymore. I suppose this was intentional.

I at least need your packet-x11.h file (and preferably also your keysymdef.h
file) in order to compile Ethereal.

Regards,

Olivier