I just checked it in, along with a rename of dfilter header field filter
strings and a dissector table.
Please note that the SMPP preferences now move to SMPP GSM SMS.
Regards,
Olivier
| -----Original Message-----
| From: Biot Olivier
|
| [ Please ignore my previous patch; it was not final ]
|
| Hi list,
|
| Attached patch does the following:
|
| * Move the GSM SMS dissection to a dedicated subdissector
| * Now higher-level dissectors show up without the need
| of unfolding the SMPP dissector subtree
| * Use the SMPP source and destination addresses for subdissection
| * Move reassembly to GSM SMS, and fix duplicate "Reassembled in"
| * Add debug logging to SMPP and SMPP GSM SMS dissector
| * Get rid of the different UDH IE subtrees, and replace them with
| one subtree for all UDH IEs
| * Add a new address type AT_STRINGZ (requires recompilation of
| all protocol dissectors)
|
| NOTE: feel free to rename AT_STRINGZ into AT_STRING :)
|
| TODO: see how we could merge Michael Lum's packet-gsm_sms.c code
| with the code in packet-smpp.c.
|
| I verified the patch with a big concatenation of traces, and
| it looks OK.
|
| Please let me know it this patch is not acceptable,
| otherwise I'll check it in.
