Ethereal-dev: Re: [Ethereal-dev] Crash in SMPP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 19 Dec 2003 19:22:55 -0800

On Dec 19, 2003, at 3:50 PM, Guy Harris wrote:


| However, that means it treats the packet as reassembled and
| hands it to the WSP dissector.

I have noticed this; I'd need to prevent this. Does the "common code"
provide a means of doing this?
No. By the time "process_reassembled_data()" has been called, the damage has already been done. 

That's why I said


| We should arrange that the aforementioned hack is
| done *ONLY* for 802.11; I'll look at doing that.
I.e., the reassembly code needs to be fixed so that the 802.11 code can say "do reassembly with this hack", and reassembly for other protocols using "fragment_add_seq_check()" doesn't do that hack.
I've checked in a change to do that. (Yes, it's ugly, but then so are 802.11 cards that reassemble frames and supply a non-zero fragment number - maybe that lets them shorten the code path a little bit in the on-card firmware, but it's still ugly....)