Ethereal-dev: Re: [Ethereal-dev] Bad offset in capture_arcnet?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 19 Dec 2003 11:05:18 -0800

On Dec 18, 2003, at 8:07 PM, Peter Fales wrote:


Somewhere between 0.9.15 and 0.10.0, packet-tacacs.c started using
the typedef u_char.   This broke our build on Irix 6.2.   I fixed
it by #including sys/bsd_types.h for or Irix build.  But, since no
other .c files reference this type,
*NO* .c files (or .h files, or any other source files) in Ethereal should be using "u_char" (or "u_short", or "u_int", or "u_long") - they should be using the "guint{8,16,32}" or "guchar" or "guint" types. I'll update "doc/README.developer". 


 perhaps it would be better to
recode packet-tacacs.c so that it doesn't use it either.


I've checked in a change to make it use "guint8".