Ethereal-dev: Re: [Ethereal-dev] patch for packet-smb.c (Locking_AndX)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Luis Claudio R. Goncalves" <lclaudio@xxxxxxxxxxxxxxxx>
Date: Thu, 4 Dec 2003 14:11:07 -0200
Hi!

On Wed, Dec 03, 2003 at 12:39:31PM -0800, Guy Harris wrote:
| 
| On Dec 3, 2003, at 2:43 AM, Ronnie Sahlberg wrote:
| 
| >AFAICS your patch reverses the patch I added to packet-smb.c # 1.366
| >and changes it back into treating this field as a 64 bit integer in
| >LittleEndian format.
| 
| The reasons I know of for not just supporting 64-bit integral types in 
| Ethereal are

The suport to 64bit integers present in etherel, using 8-byte arrays,
seems to be doing the job nicely. I mean, the discussion was not really
about 64bit integers itself but about the handling of a special case where
the protocol used two little endian 32bit words disposed as High32bit and
Low32bit - in order to be used as a 64bit value. :)

My complaint was about how the 32bit words were ordered by the code.

Sorry for my poor and _ugly_ english :)

Regards,
Luis
-- 
[ Luis Claudio R. Goncalves                  lclaudio@xxxxxxxxxxxxxxxx ]
[ Fingerprint:   4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8    ]
[ Msc has come!!!! - Conectiva HA Team - Gospel User - Linuxer - !Java ]
[ Fault Tolerance - Real-Time - Distributed Systems - IECLB - IS 40:31 ]
[ LateNite Programmer        --  My Utmost for His Highest  --         ]