Ethereal-dev: RE: [Ethereal-dev] Patch to expose OPC/DPC from MTP3, SCCP preferences
I may answer my own question with respect to the preference:
- Do it the same was as the atalk code, have a structure:
type, (ITU/ANSI/Chinese ITU)
format, (one of the ones below)
pc (guint32)
- Have an MTP3 defined function that will format based on the above
- Add an MTP3 preference for formatting style
> -----Original Message-----
> From: Michael Lum [mailto:mlum@xxxxxxxxxxxxx]
> Sent: Thursday, December 04, 2003 5:09 PM
> To: ethereal Development List
> Cc: Jeff Morriss
> Subject: RE: [Ethereal-dev] Patch to expose OPC/DPC from MTP3, SCCP
> preferences
>
>
> I wanted to make the following changes to the MTP3 dissector:
>
> 1. Add two hidden uint32 fields for 24bit OPC/DPC
> This allows display filtering using the complete 24 bit
> integer value
> as an alternative to something like "mtp3.ansi_opc == 214-170-26".
>
> i.e. "mtp3.24bit_opc == 0x66aad6" or "mtp3.24bit_opc == 6728406"
>
> 2. Modify OPC/DPC subtree label for ANSI/Chinese ITU to show the decimal
> value in addition to the current display of (x-y-z).
> i.e. DPC (214-140-5) 363734
>
> 3. Modify OPC/DPC label to show 3-8-3 in addition to the decimal
> 14 bit value
> i.e. .... .... .... .... ..00 0111 1010 0000 = DPC:
> (0-244-0) 1952
>
> Now for the AT_SS7PC formats:
>
> OK we have a few suggestions:
>
> Format TYPE decimal (for ITU/ANSI/Chinese ITU):
> decimal
>
> Format TYPE NI-decimal (for ITU/ANSI/Chinese ITU):
> NI-decimal
>
> Format TYPE "formatted":
> 8-8-8 (ANSI/Chinese ITU)
> 3-8-3 (ITU)
>
> What is the best way to allow a preference to specify an address format ?
>
> > -----Original Message-----
> > From: Jeff Morriss [mailto:morriss@xxxxxxxxx]
> > Sent: Thursday, December 04, 2003 10:48 AM
> > To: mlum@xxxxxxxxxxxxx
> > Cc: ethereal Development List
> > Subject: Re: [Ethereal-dev] Patch to expose OPC/DPC from MTP3, SCCP
> > preferences
> >
> >
> >
> >
> > Michael Lum wrote:
> > > I will add AT_SS7PC.
> > >
> > > Does anyone have any suggestions for PC formatting ?
> > >
> > >>From the packet-mtp3.c dissector I will take the following:
> > >
> > > ANSI/CHINESE ITU x-y-z where each of x, y and z are 8 bit values.
> > >
> > > ITU MTP3 Q.704 does not seem to indicate a format for the PC other
> > > than being a 14 bit value. However, I have seen it represented as
> > > a-b-c where a and c are 3 bits and b is 8 bits.
> > >
> > > Our engineers prefer the 14 or 24 bit decimal value as opposed to
> > > any formatting because then there is no ambiguity about the value.
> > >
> > > I have also seen:
> > >
> > > 8.8.8 for 24-bit point codes
> > > 3-8-3 for 14-bit
> > >
> > > I.e. the '.' versus '-' was supposed to indicate 24 versus 14 bit.
> > >
> > > Anybody else have input ?
> >
> > I have a fairly strong preference for the "8-8-8" for ANSI PC's and a
> > similar--but less strong--preference for Chinese ITU. (In fact
> I'd like
> > to, at some point, find a way for M3UA to display its point codes like
> > this instead of just decimal.)
> >
> > I've also contemplated adding a way to display ITU PCs as 3-8-3 so it
> > would be cool if this were available as a preference.
> >
