Wireshark · Ethereal-dev: Re: [Ethereal-dev] GSM MAP dissector

[Guy Harris <guy@xxxxxxxxxxxx>]

On Dec 3, 2003, at 3:32 PM, Michael Lum wrote:

> cvs diff -u from latest source:

Checked in, with Felix's name added to "doc/ethereal.pod", the 
set-but-unused "gsm_map_is_invoke" variable removed, "bigbuf[]" made 
local to the routines that use it, and the call to 
"proto_is_protocol_enabled()" and the "data_handle" variable removed 
("dissect_map()" is called through a handle, so if the protocol is 
disabled, it won't be called).

One warning:

	packet-gsm_map.c:317: warning: `Dgt_tbcd' defined but not used

Should that be used in some place, will it be used in future code, or 
should it be removed?

Also, should "my_decode_bitfield_value()" (which appears to be in a 
number of dissectors) be put into "epan/to_str.c" with a different 
name, "decode_bitfield_value()" changed to call it (the only difference 
appears to be the " = " that "decode_bitfield_value()" uses), and the 
dissectors with "my_decode_bitfield_value()" changed to use the version 
in "epan/to_str.c"?