Ethereal-dev: RE: [Ethereal-dev] tethereal doesn't seem to dissect all layers

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Michael Lum" <mlum@xxxxxxxxxxxxx>
Date: Thu, 27 Nov 2003 15:04:33 -0800
No it wasn't.

I will have to fix some of the other dissectors up that stack as well.

I copied the stuff checking where 'tree' is null, I'm not sure where it
should go.

Thanks Guy.



> -----Original Message-----
> From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
> Sent: Thursday, November 27, 2003 2:53 PM
> To: Michael Lum
> Cc: Ethereal
> Subject: Re: [Ethereal-dev] tethereal doesn't seem to dissect all layers
> 
> 
> On Thu, Nov 27, 2003 at 02:48:24PM -0800, Michael Lum wrote:
> > I can see some output from the SCCP-Lite dissector, but none of the
> > packets that contain SCCP data.
> 
> Your SCCP-Lite dissector is calling the subdissector *regardless* of
> whether "tree" is null or not, right?
> 
> If not, that's a bug - subdissectors should *always* be called;
> otherwise, if a protocol tree isn't being built, the subdissectors won't
> be called.  If you're only showing the summary in Tethereal - or when
> the file is being read in in Ethereal without color filters, taps with
> filters, or a read filter - a protocol tree is *not* built.