Wireshark · Ethereal-dev: Re: [Ethereal-dev] Ethereal performance, after Guy's changes ...

["Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>]

The RTP thing should ONLY register the tap if the user has requested it.

If that requires a complete redissection of the entire file, so be it.
All other taps require a full redissection of the entire file anyway.

Users not wanting/using RTP analysis should not be disadvantaged by having
the RTP thing
comsuming both memory and CPU.

----- Original Message ----- 
From: "Lars Ruoff"
Sent: Wednesday, November 19, 2003 7:24 PM
Subject: Re: [Ethereal-dev] Ethereal performance, after Guy's changes ...


> >
> > > I don't understand tap very well but rtp is always on ==> tree is
> > > never NULL in dissect_packet.
> >
> > That's a bug.  "register_tap_listener_rtp_stream()" should *NOT* call
> > "register_tap_listener()" - that listener should only be registered if
> > somebody *requests* that tap.
>
> Well, i asked the question the time i was submitting this, if it would be
> better to register the listener by default or register it on demand. There
> was no response at that time so i kept the registration on startup which
> sames me a lot of time.
> Note that registering the tap on demand means that the whole file does
have
> to get redissected (long on large files) before being able to show the RTP
> streams list. (Registering on startup means the RTP streams list is
> available right after file import)
> Perhaps there could be a user preference option indicating wether the tap
> should be registered on startup?
>
> regards,
> Lars Ruoff
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev