Ethereal-dev: RE: [Ethereal-dev] New dissector - how to submit?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Dave Sclarsky <Dave_Sclarsky@xxxxxxx>
Date: Tue, 18 Nov 2003 22:35:52 -0600
You can nuke the hf_ variables (or do you want me to, and make a diff?).
Thanks for the body/footer fix, I'll have to see how you did that!
DaveS.

-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Sent: Tuesday, November 18, 2003 11:28 PM
To: Dave Sclarsky
Cc: 'ethereal-dev@xxxxxxxxxxxx'
Subject: Re: [Ethereal-dev] New dissector - how to submit?



On Nov 18, 2003, at 8:11 PM, Dave Sclarsky wrote:

> aaaarg.  I hate when I do that (leave in the debug, that is)!
> Thanks for the corrections, and the checkin!

There are some unused hf_ variables:

	packet-cpfi.c:77: warning: `hf_cpfi_time_stamp' defined but not used
	packet-cpfi.c:78: warning: `hf_cpfi_TBD' defined but not used
	packet-cpfi.c:82: warning: `hf_cpfi_EOF_error' defined but not used

Are those going to be used in the future?

Also, I changed the way it handled the body and footer, so that it'll 
work even if the frame is short  (i.e., if you did a capture with a 
snapshot length not big enough for the entire frame).