Ethereal-dev: [Ethereal-dev] capture.c: seperate the mix of GTK and GUI independant things?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Thu, 13 Nov 2003 18:16:04 +0100
Hi List!
The stuff in the file "capture.c" is currently a mix of the "capturing engine" and the GTK things involved with it. 

Currently capture.c consists of three "main topics":
-generic capturing things (wiretap, pcap, ...)
-capture info GTK dialog (the one displayed when the capture is in progress)
-GTK specifics (some of the pipe handling, ...)
IMHO it would be nice to seperate the generic capturing things (leave it in the "capture.c" file) and put the GTK specific things into the gtk dir.
What I've already done (in my own source tree) is seperating the dialog things, and put it in a new file "gtk/capture_info_dlg.c" 


Questions about this task:
Is it really a good idea to do this? Or are there reasons why the current implementation is the better way? 
Is there a better name/place than "gtk/capture_info_dlg.c"?

Regards, ULFL